From: Florian Müllner <fmuellner@gnome.org>
Date: Tue, 29 Jan 2019 14:30:40 +0000 (+0100)
Subject: messageTray: Disconnect signals when resetting notification
X-Git-Tag: archive/raspbian/50.5-1+rpi1~1^2~897^2^2~103
X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=8f732e4f452a3a8df6b590a5577e2896d4e2e6cf;p=gnome-shell.git

messageTray: Disconnect signals when resetting notification

Just like we did for the parent class in commit b57832716a, we should
disconnect any notification signals when the notification is reset
to null to avoid warnings later.

https://gitlab.gnome.org/GNOME/gnome-shell/issues/942
---

diff --git a/js/ui/messageTray.js b/js/ui/messageTray.js
index 0fd739834..97452275f 100644
--- a/js/ui/messageTray.js
+++ b/js/ui/messageTray.js
@@ -497,9 +497,12 @@ class NotificationBanner extends Calendar.NotificationMessage {
         });
     }
 
-    _onDestroy() {
-        super._onDestroy();
-        this.notification.disconnect(this._activatedId);
+    _disconnectNotificationSignals() {
+        super._disconnectNotificationSignals();
+
+        if (this._activatedId)
+            this.notification.disconnect(this._activatedId);
+        this._activatedId = 0;
     }
 
     _onUpdated(n, clear) {